IPS-1118: Bau gha add lint on pre-merge and post-merge checks. #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louiseli1
approved these changes
Sep 30, 2024
louiseli1
force-pushed
the
BAU-gha-add-lint
branch
2 times, most recently
from
3da36d0 to
26b37a8
Compare
smsgds
approved these changes
Oct 17, 2024
louiseli1
force-pushed
the
BAU-gha-add-lint
branch
from
26b37a8 to
1e093e7
Compare
louiseli1
force-pushed
the
BAU-gha-add-lint
branch
from
1e093e7 to
9c0ba2e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
The following changes were required to pass the new linting steps:
W3045 # Using a legacy 'AccessControl: LogDeliveryWrite'setup for nowHealthCheckGracePeriodSeconds(this Property is only used if canaries are disabled ie if the service is using a load balancer and not managed by CodeDeploy). This was to fixE3056 | ECS service using HealthCheckGracePeriodSeconds must also have LoadBalancers specifiedE3056 See the docs at:Why did it change
Issue tracking
Other considerations